Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-336] New Version of config Adapting MAE Algorithm #1750

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

mstwutao
Copy link
Contributor

@mstwutao mstwutao commented Aug 7, 2023

Adapting New Version of config Adapting MAE Algorithm, based on open-mmlab/OpenMMLabCamp#336

Motivation

MMEngine establishes a new configuration infrastructure based on pure python style.

Modification

Add 14 config python files in mmpretrain/configs/mae/
Add 1 config python files in mmpretrain/configs/base/models/
Fix some typos

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@fangyixiao18
Copy link
Collaborator

please rebase to update the commit and run pre-commit to fix lint problem

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 96.00% and project coverage change: -19.84% ⚠️

Comparison is base (89eaa92) 85.22% compared to head (11f0502) 65.38%.
Report is 101 commits behind head on main.

❗ Current head 11f0502 differs from pull request most recent head b1d8fe0. Consider uploading reports for the commit b1d8fe0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1750       +/-   ##
===========================================
- Coverage   85.22%   65.38%   -19.84%     
===========================================
  Files         229      358      +129     
  Lines       17243    25989     +8746     
  Branches     2707     4134     +1427     
===========================================
+ Hits        14696    16994     +2298     
- Misses       2046     8377     +6331     
- Partials      501      618      +117     
Flag Coverage Δ
unittests 65.38% <96.00%> (-19.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
configs/_base_/datasets/imagenet_bs128_mbv3.py 100.00% <ø> (ø)
configs/_base_/datasets/imagenet_bs32.py 100.00% <ø> (ø)
...onfigs/_base_/datasets/imagenet_bs32_pil_resize.py 100.00% <ø> (ø)
configs/_base_/datasets/imagenet_bs64_swin_224.py 100.00% <ø> (ø)
configs/_base_/datasets/imagenet_bs64_swin_384.py 100.00% <ø> (ø)
configs/hivit/hivit-tiny-p16_16xb64_in1k.py 50.00% <50.00%> (ø)
configs/_base_/datasets/imagenet_bs64_hivit_224.py 100.00% <100.00%> (ø)
configs/_base_/models/hivit/tiny_224.py 100.00% <100.00%> (ø)
...gs/_base_/schedules/imagenet_bs1024_adamw_hivit.py 100.00% <100.00%> (ø)
configs/dinov2/vit-base-p14_dinov2-pre_headless.py 100.00% <100.00%> (ø)
... and 1 more

... and 173 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstwutao
Copy link
Contributor Author

I have run pre-commit, please check, thanks!

@mzr1996 mzr1996 merged commit 6474d6b into open-mmlab:main Aug 14, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants