Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 201/624: Updates To Status Routes #728

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Issue 201/624: Updates To Status Routes #728

wants to merge 8 commits into from

Conversation

naphelps
Copy link
Member

@naphelps naphelps commented Oct 31, 2024 •
edited
Loading

References:

Changes:

  • Issue 201: The number of registered and unregistered Nodes has been added as reported metrics.
  • Issue 624: Http 404 is returned when referencing an non-existent Organization.
  • Rebuilt ../admin/status
  • Rebuilt ../admin/orgstatus
  • Rebuilt ../org/{org}/status
  • Fixed some issues with generated swagger document
  • Minor dependency cleanup.
  • Minor whitespace adjustment
  • SBT 1.10.1 -> 1.10.5

@naphelps naphelps requested a review from omordyk November 4, 2024 14:36
@naphelps naphelps mentioned this pull request Nov 4, 2024
Closed
omordyk
omordyk approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@omordyk omordyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build.sbt

"ch.qos.logback" % "logback-classic" % "1.5.6",
//"net.logstash.logback" % "logstash-logback-encoder" % "[7.4,)",
// "com.typesafe.slick" %% "slick" % "[3.3.3]", // Version 3.4.1 depends on slick-pg and slick-pg_json4s v0.21.0
"com.typesafe.slick" %% "slick-hikaricp" % "[3.4.1]", // Version 3.4.1 depends on slick-pg and slick-pg_json4s v0.21.0
// "com.github.tminglei" %% "slick-pg" % "[0.20.4]", // Version 0.21.0 depends on version 3.4.0 of slick and slick-hikaricp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to delete thi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omordyk omordyk omordyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naphelps @omordyk