Fix vulnerabilities CWE-113 (issue #4208 issue #4209) #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
This was
linked to
issues
Dec 16, 2024
|
Ran SAST(Contrast) and checked that vulnerabilities were fixed. |
|
Hi guys. Pls check my PR. |
LiilyZhang
reviewed
Jan 7, 2025
agreementbot/api.go
Outdated
| "sort" | ||
| "sync" | ||
| "time" | ||
|
|
There was a problem hiding this comment.
Can you undo the changes in import? Same for api/api.go
There was a problem hiding this comment.
@omordyk Please see the above comment, the rest looks good
kroczi
reviewed
Jan 9, 2025
agreementbot/api.go
Outdated
Comment on lines
335
to
336
| if !isValidInput(input) { | ||
| http.Error(w, "Invalid input", http.StatusBadRequest) |
There was a problem hiding this comment.
Can the error message be more specific?
Same below.
omordyk
force-pushed
the
security_4208_4209
branch
from
74b5207 to
61745d6
Compare
|
@omordyk Please combine your commits into 1 commit, thanks |
Signed-off-by: Oleksandr Mordyk <[email protected]>
omordyk
force-pushed
the
security_4208_4209
branch
from
cac2bf0 to
c2f60bd
Compare
LiilyZhang
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Software places user-controlled input in HTTP headers. An attacker could inject line separators (CR/LF sequences) that could split the response message generated by the software into two messages. The second response is completely under the control of the attacker (intermediate web proxies may cache it), with could produce multiple conditions (web defacement, cache poisoning, cross-site scripting or page hijacking, see CWE-113 for full details). If software needs to generate HTTP headers depending on user-controlled input, such input should be properly neutralized (a white-list validation excluding CR/LF is recommended). Please note that cookies are received and sent in 'Cookie' header in HTTP messages, so if the software generates a Cookie from user input, the input should be properly validated as well.
issue #4208
issue #4209
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
make and make testChecklist: