Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output log clarity for palmctl uninstall openhorizon #4180

Conversation

Yummikko
Copy link

@Yummikko Yummikko commented Dec 4, 2024

Bug Description

Output log for 'palmctl uninstall openhorizon' command needs better clarity as it's confusing from a user perspective:
Zrzut ekranu 2024-12-4 o 15 51 47

Changes

Added --ignore-not-found and -f flags to prevent errors related to missing resources.

Fixes #4181

@Yummikko Yummikko self-assigned this Dec 4, 2024
@Yummikko Yummikko requested a review from LiilyZhang December 4, 2024 15:12
Copy link
Contributor

@LiilyZhang LiilyZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to the following:
Issue open-horizon#4181 - Bug: Output log for agent uninstall needs better clarity

@Yummikko Yummikko force-pushed the fix_3275_clarify_uninstall_log_output branch from fa35abc to 4f6666b Compare December 5, 2024 11:28
@Yummikko Yummikko requested a review from LiilyZhang December 5, 2024 11:28
@LiilyZhang LiilyZhang merged commit d190a90 into open-horizon:master Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants