Feature Request: Workload Runtime Security - installation wrapper script draft - Issue-#4115 #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue open-horizon#4115 - Workload Runtime Security - installation wrapper script Signed-off-by: Adhishree Kadam <[email protected]>
Issue open-horizon#4115- added steps 1 and 2 Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Sze Yan <[email protected]>
Issue open-horizon#4115- added steps 3-6 Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Sze Yan <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: adhishreekadam <[email protected]>
Signed-off-by: Sze Yan <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Adhishree Kadam <[email protected]>
Signed-off-by: Sze Yan <[email protected]>
dlarson04
requested changes
Sep 22, 2024
|
|
||
| # Step 13: Check if the operator is up in the cluster | ||
| echo "Checking if the operator is up in the cluster" | ||
| kubectl get pods -n openhorizon-agent |
There was a problem hiding this comment.
you should not hard code that the namespace is openhorizon-agent. You should provide a way to provide an environment variable.. Something like
export AGENT_NAMESPACE=${AGENT_NAMESPACE:-openhorizon-agent}
|
|
||
| # Step 2: Create a new working directory for a new horizon project | ||
| echo "Create a new working directory for a new horizon project" | ||
| hzn dev service new -V 1.0.0 -s kubearmor-operator -c cluster |
There was a problem hiding this comment.
you are assuming the hzn executable is installed without checking for it.. I think you check for it and for jq
|
|
||
| # Step 7: Publish operator service | ||
| echo "Publishing operator service" | ||
| hzn exchange service publish -f horizon/service.definition.json |
There was a problem hiding this comment.
Think you should use $SERVICE_DEF_JSON env variable on the publish command
|
|
||
| # Step 11: Register your edge cluster with your new node policy | ||
| echo "Registering edge cluster with new node policy" | ||
| hznpod register -u $HZN_EXCHANGE_USER_AUTH |
There was a problem hiding this comment.
What is hznpod ? That needs to be defined somewhere
| { "name": "example", "value": "kubearmor-operator" } | ||
| ] | ||
| } | ||
| EOF |
There was a problem hiding this comment.
This is setting the property as a top level property. You should use the new deployment properties instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Kube armor installation wrapper script draft
Fixes #4115
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: