Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue open-horion#4098 - Bug: Change "pvcSize" to "pvcSizeGB" #4130

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LiilyZhang
Copy link
Contributor

@LiilyZhang LiilyZhang commented Aug 6, 2024

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@LiilyZhang LiilyZhang force-pushed the zhangl/Issue4098 branch 2 times, most recently from 00ebbd0 to d043d40 Compare August 8, 2024 13:52
@dlarson04
Copy link
Contributor

dlarson04 commented Aug 8, 2024

you also need to change what is emitted from

hzn dev service new -c cluster

That has

    "clusterDeployment": {
        "mmsPVC": {
            "enable": false,
            "pvcSize": 0
        },
        "operatorYamlArchive": ""
    }

Never mind... You got this already

@LiilyZhang LiilyZhang merged commit ced51ca into open-horizon:master Aug 8, 2024
3 checks passed
@LiilyZhang LiilyZhang deleted the zhangl/Issue4098 branch August 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants