Issue #4111 - Bug: secret_exists column not added to secrets_policy i…

[MaxMcAdam]

…f table already exists

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings
• I have tagged the reviewers in a comment below incase my pull request is ready for a review
• I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

[dlarson04]

I am wondering if it would be better to still fail on error but change the SQL to be
ALTER TABLE secrets_policy ADD COLUMN IF NOT EXISTS "secret_exists" BOOLEAN NOT NULL DEFAULT true

[dlarson04]

I don't think this logic is correct.. I think it needs to be

                                // Run each SQL statement in the array of SQL statements for the current version.
                                for si := 0; si < len(migrationSQL[v].sql); si++ {
                                        if _, err := db.db.Exec(migrationSQL[v].sql[si]); err != nil && migrationSQL[v].exitOnFailure {
                                                return errors.New(fmt.Sprintf("unable to run SQL migration statement version %v, index %v, statement %v, error: %v", v, si, migrationSQL[v].sql[si], err))
                                        } else if err != nil {
                                                fmt.Printf("unable to run SQL migration statement version %v, index %v, statement %v, error: %v", v, si, migrationSQL[v].sql[si], err)
                                        }
                                }
                                if _, err := db.db.Exec(VERSION_UPDATE, HIGHEST_DATABASE_VERSION, migrationSQL[v].description); err != nil {
                                        return errors.New(fmt.Sprintf("unable to create version table, error: %v", err))
                                } else {
                                        glog.V(3).Infof("Postgresql database tables upgraded to version %v, %v", v, migrationSQL[v].description)
                                }

You don't want the version to be updated unless all the sql's were execute... Also, in my test, the version never actually got updated.

[dlarson04]

This should be a log message