Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue open-horizon#3814 - MultiNamespace: Agent should utilize IS_NAM… #3824

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

LiilyZhang
Copy link
Contributor

@LiilyZhang LiilyZhang commented Jun 26, 2023

…ESPACE_SCOPED environment variable to indicate its scope when deploy the service

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@LiilyZhang LiilyZhang force-pushed the zhangl/Issue3814 branch 2 times, most recently from 4af4226 to ba7af6c Compare July 18, 2023 17:49
@LiilyZhang LiilyZhang force-pushed the zhangl/Issue3814 branch 10 times, most recently from 1d0ffda to bb8b4d0 Compare July 28, 2023 14:39
@LiilyZhang LiilyZhang changed the title (Not Ready)Issue open-horizon#3814 - MultiNamespace: Agent should utilize IS_NAM… Issue open-horizon#3814 - MultiNamespace: Agent should utilize IS_NAM… Jul 28, 2023
…ESPACE_SCOPED environment variable to indicate its scope when deploy the service

Signed-off-by: Le Zhang <[email protected]>
@LiilyZhang LiilyZhang merged commit 58217e7 into open-horizon:master Aug 1, 2023
3 checks passed
@LiilyZhang LiilyZhang deleted the zhangl/Issue3814 branch August 1, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants