-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add appendix b, gherkin suite #203
Conversation
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Todd Baert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Todd Baert <[email protected]>
dbb9779
to
44b7abc
Compare
@liran2000 I merged your change. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Adds a new appendix for gherkin suites, taken from https://github.com/open-feature/test-harness. This is especially useful/relevant now that implementations are including their own in-memory providers. Implementations can use this suite + their in-memory provider for a robust suite of e2e tests.
Eventually, I'd like to add a "events" test suite too, but for now I'm only including the
evaluation.feature
.