feat: add appendix b, gherkin suite #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
Kavindu-Dodan,
justinabrahms,
weyert,
jamescarr,
federicobond,
dabeeeenster,
beeme1mr,
thisthat,
jonathannorris,
josecolella,
benjiro,
thiyagu06,
kinyoklion,
lopitz,
Billlynch,
fabriziodemaria,
hlipsig,
tcarrio,
thomaspoignant,
lukas-reining and
liran2000
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Aug 28, 2023
Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/gherkin-suites
branch
from
dbb9779
to
44b7abc
Compare
|
@liran2000 I merged your change. Thanks. |
liran2000
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new appendix for gherkin suites, taken from https://github.com/open-feature/test-harness. This is especially useful/relevant now that implementations are including their own in-memory providers. Implementations can use this suite + their in-memory provider for a robust suite of e2e tests.
Eventually, I'd like to add a "events" test suite too, but for now I'm only including the
evaluation.feature.