Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split lint job into lint and sast #256

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Jan 6, 2024

This PR

  • typically CodeQL scanning takes longer than other steps, therefore it is better to have a dedicated job for it
  • also removed the Install dependencies step, because there are no dependencies needed for scanning the project (this could change in the future and then it would make sense to split into 2 different requirements.txt files or use something like poetry to handle dev and runtime dependencies)

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3c67b6) 93.83% compared to head (d81b8d5) 93.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          16       16           
  Lines         438      438           
=======================================
  Hits          411      411           
  Misses         27       27           
Flag Coverage Δ
unittests 93.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@federicobond
Copy link
Member

What do you think about running CodeQL only for merged commits (on main branch)?

@gruebel
Copy link
Member Author

gruebel commented Jan 6, 2024

From my experience it is usually too late. If you for example added some suspicious code, then it is merged and flagged, and you will need to either exclude those lines or fix them in a follow-up PR.

@federicobond federicobond merged commit 30f4e69 into open-feature:main Jan 8, 2024
13 checks passed
@gruebel gruebel deleted the split-sast branch January 8, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants