-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace black, fake8 and isort with ruff and ruff-format #249
Conversation
Signed-off-by: gruebel <[email protected]>
hey @federicobond and @beeme1mr created a new PR, which only does the ruff addition. Will do the code adjustments in a follow-up PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 16 16
Lines 443 443
=======================================
Hits 414 414
Misses 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gruebel <[email protected]>
Signed-off-by: Anton Grübel <[email protected]>
Hey @gruebel, sorry for the delay here. Most of the team was out for the holidays. Things should speed up now that people are coming back 😄 |
Signed-off-by: gruebel <[email protected]>
@beeme1mr no problem 😄 Fixed the issue with the missing GHA version tag. It looks like they don't offer a shortened variant for it. I usually use commit hashes to pin all GHA versions. Are you interested in it or you want to keep it as is? |
I have a slight preference for version tags because they're easier to understand at a glance but I would be fine with either approach. |
All good, then let's keep as it is 🙂 |
I'll give @federicobond more time since he's our resident Python expert 😄 |
Sorry for the delay! I think this is good to merge. It's hard to understand all the implications of moving to a new set of style rules, but this moves us in the right direction regarding tooling, and if it turns out we need to fine-tune the config we can adjust it later. |
This PR
black
,flake8
andisort
withruff
andruff-format
flake8
and the plugins you mentioned in thepre-commit
configpre-commit
action insteadRelated Issues
Fixes #219
Notes
Follow-up Tasks
How to test