Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement tracking as per spec #1020

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat: implement tracking as per spec #1020

merged 7 commits into from
Oct 29, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 20, 2024

📣 This was a draft for a while, but is now ready for review! 📣

This implements tracking as per spec, in the server, web, and react SDKs.
I don't think the Angular or Nest SDKs need specific implementations, but please advise (cc @luizgribeiro @lukas-reining).

Fixes: #1033
Fixes: #1034

toddbaert added a commit that referenced this pull request Oct 16, 2024
Inspired by [this
comment](#1020 (comment))
I've added a lint rule to enforce `import type`, and some additional
package changes to add a `lint:fix`.

The only changes I made manually here is to add the lint rule, and the
package.json script. All the changes are auto-generated by the
`lint:fix`.

---------

Signed-off-by: Todd Baert <[email protected]>
The `tracking API` enables the association of feature flag evaluations with subsequent actions or application states, in order to facilitate experimentation and analysis of the impact of feature flags on business objectives.

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@beeme1mr beeme1mr requested a review from wichopy October 21, 2024 18:30
Copy link
Member

@wichopy wichopy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Would be nice to hook it up to @beeme1mr s test app?

@toddbaert
Copy link
Member Author

Lgtm. Would be nice to hook it up to @beeme1mr s test app?

That's the plan!

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left two minor comments :)

packages/server/src/client/internal/open-feature-client.ts Outdated Show resolved Hide resolved
packages/server/src/provider/provider.ts Outdated Show resolved Hide resolved
@toddbaert
Copy link
Member Author

I'm merge this tomorrow unless I hear objections

@toddbaert toddbaert added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 80f182e Oct 29, 2024
8 checks passed
@toddbaert toddbaert deleted the feat/tracking branch October 29, 2024 13:47
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](core-v1.4.0...core-v1.5.0)
(2024-10-29)


### ✨ New Features

* implement tracking as per spec
([#1020](#1020))
([80f182e](80f182e))


### 🧹 Chore

* import type lint rule and fixes
([#1039](#1039))
([01fcb93](01fcb93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](web-sdk-v1.2.4...web-sdk-v1.3.0)
(2024-10-29)


### ✨ New Features

* implement tracking as per spec
([#1020](#1020))
([80f182e](80f182e))


### 🧹 Chore

* import type lint rule and fixes
([#1039](#1039))
([01fcb93](01fcb93))
* **main:** release core 1.5.0
([#1040](#1040))
([fe3ad8e](fe3ad8e))


### 📚 Documentation

* update domain context terminology
([#1037](#1037))
([924802b](924802b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.7](react-sdk-v0.4.6...react-sdk-v0.4.7)
(2024-10-29)


### ✨ New Features

* avoid re-resolving flags unaffected by a change event
([#1024](#1024))
([b8f9b4e](b8f9b4e))
* implement tracking as per spec
([#1020](#1020))
([80f182e](80f182e))
* use mutate context hook
([#1031](#1031))
([ec3d967](ec3d967))


### 🧹 Chore

* add js docs for context mutator hook
([#1045](#1045))
([def3fe8](def3fe8))
* import type lint rule and fixes
([#1039](#1039))
([01fcb93](01fcb93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert added a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.16.0](server-sdk-v1.15.1...server-sdk-v1.16.0)
(2024-10-29)


### ✨ New Features

* implement tracking as per spec
([#1020](#1020))
([80f182e](80f182e))


### 🧹 Chore

* import type lint rule and fixes
([#1039](#1039))
([01fcb93](01fcb93))
* **main:** release core 1.5.0
([#1040](#1040))
([fe3ad8e](fe3ad8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Tracking for JS (Web) [FEATURE] Implement Tracking for JS (Server)
7 participants