fix: typo + missing bin directory #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewilhelm
previously approved these changes
Aug 20, 2024
hilmarf
requested changes
Aug 21, 2024
|
sorry, was too fast with my comment... ok, bin directory is missing... when? Shouldn't the make target ensure that it is created when necessary instead of having an empty file lying around 💭 |
frewilhelm
reviewed
Aug 21, 2024
@hilmarf Sure, you are totally right. I was trying out different ways to make the |
hilmarf
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR fixes typos.
Additionally, it fixes the Make target
make install-requirementsbecause of missingbindirectory.