Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maven issues #790

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

fabianburth
Copy link
Contributor

@fabianburth fabianburth commented Jun 3, 2024

Description

This PR fixes upload issues and introduces the option to upload blob during composition. So, you can now do the following:
ocm add cv --file /tmp/ctf components.yaml --uploader ocm/mavenArtifact=file://localhost/mavenrepo
with the components.yaml looking something like this:

components:
- name: ocm.software/demo/test
  version: 1.0.0
  provider:
    name: ocm.software
  resources:
    - name: mavenartifact
      type: mavenArtifact
      input:
        type: maven
        path: /maven/testdata/.m2/repository
        groupId: "com.sap.cloud.sdk"
        artifactId: "sdk-modules-bom"
        version: "5.7.0"

For the uploader to trigger here (and therefore, for the uploader option to be effective with this command), it is crucial that you try to add a local blob (and thus, have an input: instead of an access: in your constructor file).

@fabianburth fabianburth requested a review from mandelsoft June 3, 2024 12:33
@fabianburth fabianburth self-assigned this Jun 3, 2024
hilmarf
hilmarf previously approved these changes Jun 3, 2024
@fabianburth fabianburth changed the title throw error for empty repo url fix maven issues Jun 3, 2024
@fabianburth fabianburth merged commit 4f6c9eb into open-component-model:main Jun 4, 2024
14 checks passed
@fabianburth fabianburth deleted the maven-fix branch June 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

2 participants