Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse and validate some input parameters as filesystem-paths #669

Merged
merged 17 commits into from
Feb 23, 2024
Merged

parse and validate some input parameters as filesystem-paths #669

merged 17 commits into from
Feb 23, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Feb 20, 2024 •
edited
Loading

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hilmarf hilmarf requested a review from mandelsoft February 20, 2024 13:27
@github-actions github-actions bot added the size/m Medium label Feb 20, 2024
@hilmarf hilmarf linked an issue Feb 20, 2024 that may be closed by this pull request
Using --input to add resources on Windows causes yaml error #648
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited
Loading

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 20, 2024

Integration Tests for 2ddf3fe run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 20, 2024

Integration Tests for 2ddf3fe run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 22, 2024

Integration Tests for 137c796 run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 22, 2024

Integration Tests for 137c796 run with result: Success ✅!

@github-actions github-actions bot added size/l Large and removed size/m Medium labels Feb 22, 2024
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 22, 2024

Integration Tests for 137c796 run with result: Success ✅!

@github-actions github-actions bot added size/m Medium and removed size/l Large labels Feb 23, 2024
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 23, 2024

Integration Tests for 137c796 run with result: Success ✅!

@hilmarf hilmarf marked this pull request as ready for review February 23, 2024 11:55
hilmarf
hilmarf commented Feb 23, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
hilmarf
hilmarf commented Feb 23, 2024
View reviewed changes
go.mod Show resolved Hide resolved
mandelsoft
mandelsoft requested changes Feb 23, 2024
View reviewed changes
go.mod Show resolved Hide resolved
pkg/cobrautils/flag/path.go Show resolved Hide resolved
pkg/cobrautils/flag/path_array.go Show resolved Hide resolved
pkg/cobrautils/flag/replace.go Outdated Show resolved Hide resolved
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 23, 2024

Integration Tests for 929d0ea run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 23, 2024

Integration Tests for 929d0ea run with result: Success ✅!

@hilmarf hilmarf enabled auto-merge (squash) February 23, 2024 15:12
@mandelsoft mandelsoft self-requested a review February 23, 2024 15:12
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Feb 23, 2024

Integration Tests for 929d0ea run with result: Success ✅!

@hilmarf hilmarf merged commit cb203c0 into main Feb 23, 2024
17 checks passed
@hilmarf hilmarf deleted the fix/648 branch February 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft mandelsoft approved these changes

Assignees
No one assigned
Labels
size/m Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using --input to add resources on Windows causes yaml error
2 participants
@hilmarf @mandelsoft