Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Command to check completeness of a component version graph #644

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Feb 7, 2024

## Description

The new command ocm check componentversion checks component versions in an OCM
repository to be complete. All directly or indirectly references versions must also be
available in the repository of the initially checked one.

Additionally, it checks for cycles and may be more consistency conditions in the future.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hilmarf hilmarf linked an issue Feb 9, 2024 that may be closed by this pull request
@ikhandamirov
Copy link
Contributor

@mandelsoft, please see my question in #518

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments at the coding would be great to easier understand what's going on... e.g. GoDoc at function

@mandelsoft mandelsoft merged commit ed906a3 into open-component-model:main Feb 16, 2024
13 of 14 checks passed
@mandelsoft mandelsoft deleted the command branch February 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for feeding RBSC
3 participants