Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ref detection for ca/ctf #607

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Dec 21, 2023

Description

Parsing a command line repository spec is improved to better distinguish CA and CTF variants.

A CTF is only enforced if the target has

  • either the required descriptor file
  • or if has no files

This gives spec handlers later in the list the chance to detect their type.

May be, a rework would be useful, where handlers distinguish between a default and a direct match.
So far, the first match exists the handler processing. With a default match, all handlers could be executed to look
for a direct match. A default match would only be used if no direct match is found.

Second problem is the compound resolver. If a component archive is used as resolver, if reports a not found error
for the component, instead of the requested component version. The error condition is fixed accordingly.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

fabianburth
fabianburth previously approved these changes Dec 21, 2023
@mandelsoft mandelsoft merged commit fade9c4 into open-component-model:main Dec 27, 2023
11 of 12 checks passed
@mandelsoft mandelsoft deleted the fix branch December 27, 2023 09:05
@mandelsoft mandelsoft restored the fix branch December 27, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants