separate package blobaccess #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
previously approved these changes
Oct 18, 2023
| "github.com/open-component-model/ocm/pkg/errors" | ||
| "github.com/open-component-model/ocm/pkg/mime" | ||
| "github.com/open-component-model/ocm/pkg/utils" | ||
| "github.com/open-component-model/ocm/pkg/utils/tarutils" | ||
| ) | ||
|
|
||
| func DataAccessForDirTree(path string, opts ...Option) (accessio.DataAccess, error) { | ||
| func DataAccessForDirTree(path string, opts ...Option) (spi.DataAccess, error) { |
There was a problem hiding this comment.
Maybe rename this to bpi (for blob programming interface). That might be slightly more intuitive.
There was a problem hiding this comment.
good ides, this would be consistent with the used naming scheme in the lib.
I'll do this when moving the package to the top level pkg folder
|
I had to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves all flavors of implementations of interface
BlobAccessto the packageblobaccessand deprecates the old locations.All usages in the lib are adjusted to not access the deprecated types and functions, anymore.
This is the first step to a clearer interface towards a uniform composition API for component versions.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: