Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to preferred new $defs #536

Merged
merged 4 commits into from
Jan 29, 2024
Merged

switch to preferred new $defs #536

merged 4 commits into from
Jan 29, 2024

Conversation

morri-son
Copy link
Contributor

Description

change to the preferred new $defs in the JSON spec

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/m Medium label Oct 9, 2023
@ocmbot
Copy link
Contributor

ocmbot bot commented Oct 9, 2023

Integration Tests for 58d11622321d0d7ec715f3cf525f43b8f4f8068a run with result: Success ✅!

mandelsoft
mandelsoft previously approved these changes Nov 30, 2023
@morri-son morri-son dismissed mandelsoft’s stale review November 30, 2023 12:34

The merge-base changed after approval.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 0
LICENSE RISK HIGH 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 1

Detailed Logs: mend-scan-> Generate Report
Mend UI

@mandelsoft mandelsoft merged commit 1004c32 into main Jan 29, 2024
15 checks passed
@mandelsoft mandelsoft deleted the JSON-Schema-improvements branch January 29, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants