fix(workaround): allow old norm algos to be hashed with old digest ctxts #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewilhelm
previously approved these changes
Jan 21, 2025
jakobmoellerdev
force-pushed
the
fix/digest-propagation-with-normalization
branch
from
0c5623f to
b447ac6
Compare
github-actions
bot
added
the
component/github-actions
This make sure that the (very convoluted) signing implementation normalizes with the legacy patch we applied during the normalization of the descriptor to avoid mismatches in resource identities during digest propagation.
jakobmoellerdev
force-pushed
the
fix/digest-propagation-with-normalization
branch
from
b447ac6 to
4848119
Compare
frewilhelm
approved these changes
Jan 21, 2025
frewilhelm
pushed a commit
to frewilhelm/ocm
that referenced
this pull request
Jan 21, 2025
…xts (open-component-model#1263) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This make sure that the (very convoluted) signing implementation normalizes with the legacy patch we applied during the normalization of the descriptor to avoid mismatches in resource identities during digest propagation. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> fix open-component-model#1245
frewilhelm
added a commit
that referenced
this pull request
Jan 21, 2025
…xts (#1264) backport #1263 into v0.19 Co-authored-by: Jakob Möller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This make sure that the (very convoluted) signing implementation normalizes with the legacy patch we applied during the normalization of the descriptor to avoid mismatches in resource identities during digest propagation.
Which issue(s) this PR fixes
fix #1245