Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to close, unable to unref last: unable to cleanup component version, while unref last: closing component version #1243

Merged
merged 6 commits into from
Jan 14, 2025
Merged

fix: unable to close, unable to unref last: unable to cleanup component version, while unref last: closing component version #1243

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2dc0134
fixes: https://github.com/open-component-model/ocm/issues/1235
hilmarf Jan 10, 2025
4d7d05f
check if version contained '+',
hilmarf Jan 13, 2025
7922302
Merge branch 'main' into fixes/unref_last
hilmarf Jan 13, 2025
1b7bb35
add test
hilmarf Jan 14, 2025
c1546d2
no 'else'
hilmarf Jan 14, 2025
a6cf2d2
Merge branch 'main' into fixes/unref_last
hilmarf Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/ocm/extensions/repositories/genericocireg/component.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ func (c *componentAccessImpl) HasVersion(vers string) (bool, error) {
}

func (c *componentAccessImpl) LookupVersion(version string) (*repocpi.ComponentVersionAccessInfo, error) {
// LookupVersion '0.0.1-20250108132333.build-af79499' would fail with:
// unable to unref last: unable to cleanup component version [%v] while unref last: closing component version [%v]: check failed: component version [%v] is invalid
hilmarf marked this conversation as resolved.
Show resolved Hide resolved
// This is because the version comes from an artifact tag, which doesn't allow '+' characters, which we replace with '.build-' during the push
version = toVersion(version) // ensure the cv doesn't contain '.build-'
tag, err := toTag(version)
if err != nil {
return nil, err
Expand Down
Loading