feat(log): log http requests for OCI and docker based on trace level by injecting a logger #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is now possible to inject a trace attribute to OCMs logging architecture to allow tracing back HTTP calls for oci registries and the docker client: ``` ocm --logkeys /+ocm/oci=trace [YOUR COMMAND INTERACTING WITH OCI HERE] ``` Note that this does not take care of all access types yet because we dont have a unified http.Client
jakobmoellerdev
added
kind/feature
jakobmoellerdev
changed the title
jakobmoellerdev
changed the title
jakobmoellerdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
it is now possible to inject a trace attribute to OCMs logging architecture to allow tracing back HTTP calls for oci registries and the docker client:
Note that this does not take care of all access types yet because we dont have a unified http.Client.
Note that it is now also possible to pass
/+ocm/docker=traceto enable logging for the docker client infrastructure, or set--loglevel=traceto get a full tracelog with HTTP statements.Authorization Headers are redacted
Which issue(s) this PR fixes