fix implicit version handling of an artifact identity #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would you mind separating this into
I will continue reviewing the existing fix for the implicit version handling |
mandelsoft
force-pushed
the
version
branch
2 times, most recently
from
e723f76 to
6981451
Compare
mandelsoft
force-pushed
the
version
branch
4 times, most recently
from
e1b5515 to
05cbf1b
Compare
unified handling of modification of elements ocm hash tests generate reference doc revert oci related changes
mandelsoft
commented
Nov 11, 2024
jakobmoellerdev
approved these changes
Nov 12, 2024
jakobmoellerdev
added a commit
to jakobmoellerdev/ocm
that referenced
this pull request
Dec 30, 2024
…omponent-model#1026)" This reverts commit 782970c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The defaulting of the extraIdentity did only work, if there was an identity map already set.
So far the version was implicutly added to the extraIdentity of a CV if the rest is not
unique. In the future the extraIdentity should be explicitly set to be unique. Therefore,
the version was now implicitly added to the extraIdentity. This has two problems:
To be comparable with older signed component versions, such defaulting may only be done
if the content of a component version is changed, otherwise the signature would be brocken.
Which issue(s) this PR fixes