Fix Helm Downloader Credential Handling (#571)

* fix credential not being used * restructure nested if
open-component-model · Nov 10, 2023 · d79f074 · d79f074
1 parent 8dfdd01
commit d79f074
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/helm/downloader.go b/pkg/helm/downloader.go
@@ -101,12 +101,12 @@ func DownloadChart(out common.Printer, ctx oci.ContextProvider, ref, version, re
 func (d *chartDownloader) complete(ctx oci.ContextProvider, ref, repourl string) error {
 	rf := repo.NewFile()
 
-	creds := d.creds
 	if d.creds == nil {
 		d.creds = identity.GetCredentials(ctx.OCIContext(), repourl, ref)
-		if d.creds == nil {
-			creds = common.Properties{}
-		}
+	}
+	creds := d.creds
+	if creds == nil {
+		creds = common.Properties{}
 	}
 
 	config := vfs.Join(d.fs, d.root, ".config")