Skip to content

Commit

Permalink
chore(signing): correct Fulcio service to correct address (#1135)
Browse files Browse the repository at this point in the history
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
correct Fulcio service to correct address, as currecnt address leads to
"no host found" when traing to sign using cosign

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

---------

Co-authored-by: Hilmar Falkenberg <[email protected]>
  • Loading branch information
morri-son and hilmarf authored Nov 25, 2024
1 parent 3133edf commit 9033cb5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions api/tech/signing/handlers/sigstore/attr/attr.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const (

var defaultAttr = Attribute{
// https://github.com/tektoncd/chains/blob/main/docs/config.md#keyless-signing-with-fulcio
FulcioURL: "https://v1.fulcio.sigstore.dev",
FulcioURL: "https://fulcio.sigstore.dev",
RekorURL: "https://rekor.sigstore.dev",
OIDCIssuer: "https://oauth2.sigstore.dev/auth",
OIDCClientID: "sigstore",
Expand Down Expand Up @@ -46,7 +46,7 @@ func (a AttributeType) Description() string {
return `
*sigstore config* Configuration to use for sigstore based signing.
The following fields are used.
- *<code>fulcioURL</code>* *string* default is https://v1.fulcio.sigstore.dev
- *<code>fulcioURL</code>* *string* default is https://fulcio.sigstore.dev
- *<code>rekorURL</code>* *string* default is https://rekor.sigstore.dev
- *<code>OIDCIssuer</code>* *string* default is https://oauth2.sigstore.dev/auth
- *<code>OIDCClientID</code>* *string* default is sigstore
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/ocm.md
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ The value can be a simple type or a JSON/YAML string for complex values
- <code>ocm.software/signing/sigstore</code> [<code>sigstore</code>]: *sigstore config* Configuration to use for sigstore based signing.

The following fields are used.
- *<code>fulcioURL</code>* *string* default is https://v1.fulcio.sigstore.dev
- *<code>fulcioURL</code>* *string* default is https://fulcio.sigstore.dev
- *<code>rekorURL</code>* *string* default is https://rekor.sigstore.dev
- *<code>OIDCIssuer</code>* *string* default is https://oauth2.sigstore.dev/auth
- *<code>OIDCClientID</code>* *string* default is sigstore
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/ocm_attributes.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ OCM library:
- <code>ocm.software/signing/sigstore</code> [<code>sigstore</code>]: *sigstore config* Configuration to use for sigstore based signing.

The following fields are used.
- *<code>fulcioURL</code>* *string* default is https://v1.fulcio.sigstore.dev
- *<code>fulcioURL</code>* *string* default is https://fulcio.sigstore.dev
- *<code>rekorURL</code>* *string* default is https://rekor.sigstore.dev
- *<code>OIDCIssuer</code>* *string* default is https://oauth2.sigstore.dev/auth
- *<code>OIDCClientID</code>* *string* default is sigstore
Expand Down

0 comments on commit 9033cb5

Please sign in to comment.