Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable: markdown lint + check: links + spelling #308

Merged
merged 48 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
b7f0f79
enable: markdown lint + check: links + spelling
hilmarf Aug 19, 2024
bdbca80
Merge branch 'main' into verify/markdown
hilmarf Aug 19, 2024
795d80b
this is obviosly just a copy paste from Doks repo... nothing related to
hilmarf Aug 19, 2024
445eaf5
renaming the steps for more clarity
hilmarf Aug 19, 2024
97bd688
fix links
hilmarf Aug 19, 2024
ffb8839
fix some typos
hilmarf Aug 19, 2024
66875a7
fix some linter issues
hilmarf Aug 19, 2024
fdd245d
obsolete
hilmarf Aug 19, 2024
170e06d
Merge branch 'main' into verify/markdown
hilmarf Aug 20, 2024
6d05d9d
uses: untitaker/hyperlink@v0
hilmarf Aug 21, 2024
a7e6c60
bump node, npm, pnpm
hilmarf Aug 21, 2024
51e89d1
"license": "Apache-2.0"
hilmarf Aug 21, 2024
0116e47
Merge branch 'main' into verify/markdown
hilmarf Aug 21, 2024
487b38d
set correct version
hilmarf Aug 21, 2024
61789a9
Merge remote-tracking branch 'refs/remotes/origin/verify/markdown' into
hilmarf Aug 21, 2024
0653b54
md lint
hilmarf Aug 21, 2024
4c27f60
link DCO
hilmarf Aug 21, 2024
7e0a3c8
typo
hilmarf Aug 21, 2024
0caddb6
linting
hilmarf Aug 21, 2024
fe5fab1
links
hilmarf Aug 21, 2024
d456bc4
fix: Privacy Policy
hilmarf Aug 22, 2024
350c57e
fix links
hilmarf Aug 22, 2024
5a8bef8
lint fix bootstrap.md:132 MD024/no-duplicate-heading
hilmarf Aug 22, 2024
ddf1499
lint fix mpas getting_started
hilmarf Aug 22, 2024
ec8877d
```bash
hilmarf Aug 22, 2024
dafb5d7
update node version + license
hilmarf Aug 22, 2024
c8b88aa
md lint
hilmarf Aug 22, 2024
f4b8296
Merge branch 'main' into verify/markdown
hilmarf Aug 23, 2024
d5c352c
Merge remote-tracking branch 'refs/remotes/origin/verify/markdown' into
hilmarf Aug 26, 2024
f7de3a0
call reusable workflow
hilmarf Aug 26, 2024
04d4311
fix: no version specified
hilmarf Aug 26, 2024
0c039f5
rename inputs
hilmarf Aug 26, 2024
ac625cb
individual link mapping
hilmarf Aug 27, 2024
503b6a7
remove timestamp
hilmarf Aug 27, 2024
60db66c
remove DisableAutoGenTag coding
hilmarf Aug 27, 2024
5edbd1c
organize import
hilmarf Aug 27, 2024
8ff6fa6
regenerate docs
hilmarf Aug 27, 2024
f779f7d
fix links
hilmarf Aug 27, 2024
10927c7
re-generate
hilmarf Aug 27, 2024
02c450f
shitty hugo - is not able to translate links correctly
hilmarf Aug 27, 2024
9e84b92
md lint
hilmarf Aug 28, 2024
baeef70
Merge branch 'main' into verify/markdown
hilmarf Aug 28, 2024
96c2473
Update publish-site.yaml
morri-son Sep 3, 2024
f4cab2e
typo
hilmarf Sep 13, 2024
c49c1c0
Merge remote-tracking branch 'refs/remotes/origin/verify/markdown' into
hilmarf Sep 13, 2024
8874320
Merge branch 'main' into verify/markdown
hilmarf Sep 13, 2024
238a31e
Merge branch 'main' into verify/markdown
hilmarf Sep 16, 2024
20bd79d
new generate
hilmarf Sep 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/config/markdownignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/content/docs/cli-reference
/content/docs/controller/controller-reference
6 changes: 6 additions & 0 deletions .github/config/markdownlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
default: true

MD013: false #Line length - https://github.com/DavidAnson/markdownlint/blob/HEAD/doc/Rules.md#md013
MD033: false #Inline HTML - https://github.com/DavidAnson/markdownlint/blob/HEAD/doc/Rules.md#md033
MD024:
siblings_only: true #Multiple headers with the same content
22 changes: 22 additions & 0 deletions .github/config/spellcheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
matrix:
- name: Markdown
aspell:
lang: en
ignore-case: true
mode: markdown
dictionary:
wordlists:
- .github/config/wordlist.txt
encoding: utf-8
pipeline:
- pyspelling.filters.markdown:
markdown_extensions:
- pymdownx.superfences
- pyspelling.filters.html:
comments: false
ignores:
- code
- pre
sources:
- '**/*.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have html sources if I am not mistaken (e.g. https://github.com/open-component-model/ocm-website/blob/main/layouts/index.html). Would it be possible to check them? Or would the html-syntax be too troublesome.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too convinced that the spell checker really makes sense for html pages and propose to keep the check for markdown only.

default_encoding: utf-8
290 changes: 290 additions & 0 deletions .github/config/wordlist.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,290 @@
accessmethod
accessmethoddescriptor
accessmethods
actiondescriptor
additionalresource
addversion
adr
aggregative
aml
anchore
api
archlinux
artifactid
aur
auth
autoconfigure
aws
backend
backends
basename
bindata
blobaccess
blobhandler
bool
boolean
buildx
cas
cli
cliconfig
clis
closable
closeable
cmds
cncf
codeql
commontransportarchive
componentaccess
componentaccessimpl
componentarchive
componentreferences
componentversionaccess
componentversionaccessimpl
componentversions
compvers
config
configfile
configs
consumerid
containerd
crd
creationtime
credentialrequest
credentialsspec
crossplatform
crypto
ctf
ctfs
ctx
cvs
deepcopy
defs
dependabot
deployscript
deserializable
deserialization
deserialize
deserialized
dest
digesters
directorytree
dirtree
dns
dockerconfig
downloadconstraint
downloader
downloaderdescriptor
downloaders
downloadhandlers
dry-run
dup
dups
dynaml
echoserver
entrypoint
executables
executoroptions
executorspecification
extensibility
filepath
filesystem
filesytem
finalizer
finalizers
foldername
forwardspec
gapped
gav
getinexpensivecontentversionidentity
getresourcesbyname
getter
ghcr
github
gitignore
gitops
globalaccess
globals
gocritic
gofmt
golang
golangci
gomega
goreleaser
gosec
goutils
groupid
gzip
handleoutput
hashers
hashicorp
hashicorpvault
helmchart
helmchartrepository
helmdemo
helmexecutor
helminstaller
helmrepository
hoc
homebrew
hostname
hostpath
html
http
https
iaas
imagemapping
inlined
installable
instantiation
io
ioutils
iterable
json
jsonschema
keyless
keypair
keyring
kubebuilder
kubeconfig
kubernetes
labelmergespecification
lifecycle
linter
linters
lister
listers
localizations
logconfig
logrus
lookups
macos
makefile
makefiles
mandelsoft
mapocirepoattr
matcher
matchers
mavenartifact
mavenpackage
mavenrepository
mediatype
mimetype
mimetypes
multiarch
mutex
mvn
mvnrepository
namespace
namespaces
newcomponentaccess
newcomponentversionaccess
newrepository
newrepositoryspec
npm
npmjs
npmrc
npmregistry
oauth
oci
ociartifact
ocireg
ociregistry
ocm
ocmbot
ocmcli
ocmconfig
oncefunc
oo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i grep -i'd for oo but did not find any occurrence. Are there any?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also didn't find any and guess oo can be removed

oras
os
outputspecification
packagespec
parameterization
pendingdeprecationwarning
pflag
podinfo
podman
pre
preconfigure
preconfigured
predefine
programmatically
prs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The occurrences of prs are PRs. Maybe we should just write pull-requests instead of adding prs to the wordlist to prevent any real typo of prs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there' the chance of misspelling PRs as Pre or pre or any other permutation, I don't want to always write Pull-request instead of PRs and am willing to live with potential "errors" here :-)

pss
pubsub
readme
readonly
refcount
relativeocireference
releaser
repo
repocpi
repositoryimpl
repositoryspec
resendbuffer
resolvers
resourcereference
routings
routingslips
rsa
rsakeypair
runtime
sbod
sbom
sdk
semver
sequent
serializable
sha
signingserver
sigstore
simplemapmerge
sonatype
spdx
srcrefs
stderr
stdin
stdout
storable
struct
subchart
subcharts
subst
tempfile
templated
templater
templaters
templating
tgz
tls
todo
toi
toiexecutor
toolset
transportarchive
typehandler
typename
unmodifiable
untrusted
updatevendorhash
uploader
uploaderdescriptor
uploaders
uploadhandlers
url
urls
utf
util
utils
valuemergehandler
valuemergehandlerdescriptor
valueset
versionedtypedobjects
walkthrough
wget
withocm
xml
yaml
yitsushi
yml
yyyy
Loading
Loading