fix the cluster name is digital

Signed-off-by: Zhiwei Yin <[email protected]>
open-cluster-management-io · Sep 19, 2024 · 7cd39e2 · 7cd39e2
1 parent 90b7a75
commit 7cd39e2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/addon/manifests/permission/rolebinding.yaml b/addon/manifests/permission/rolebinding.yaml
@@ -2,7 +2,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: open-cluster-management:addons:application-manager
-  namespace: {{ .ClusterName }}
+  namespace: "{{ .ClusterName }}"
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole

diff --git a/cmd/manager/exec/manager.go b/cmd/manager/exec/manager.go
@@ -18,6 +18,7 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
+	"math"
 	"net/http"
 	"os"
 	"strings"
@@ -245,6 +246,11 @@ func RunManager() {
 			os.Exit(1)
 		}
 
+		// Validate the LeaseDurationSeconds value to ensure it fits within int32 limits
+		if Options.LeaseDurationSeconds > math.MaxInt32 || Options.LeaseDurationSeconds < math.MinInt32 {
+			klog.Fatalf("lease-duration exceeds int32 range: %d", Options.LeaseDurationSeconds)
+		}
+
 		leaseReconciler := leasectrl.LeaseReconciler{
 			HubKubeClient:         hubKubeClient,
 			HubConfigFilePathName: Options.HubConfigFilePathName,