Fix TorrentDownloadController #1208
Open
+147
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will also close #1205 |
Him188
reviewed
Nov 17, 2024
| totalSize = 1000.kb, | ||
| pieceSize = 1.kb, | ||
| initialDataOffset = 0, | ||
| initialPieceIndex = 0, |
There was a problem hiding this comment.
还需要测试有这个 initialPieceIndex 的情况, 否则你没有测试这个 PR 尝试解决的问题 #1205
torrent/api/src/commonMain/kotlin/api/pieces/TorrentDownloadController.kt
Show resolved
Hide resolved
torrent/api/src/commonTest/kotlin/api/pieces/TorrentDownloadControllerTest.kt
Show resolved
Hide resolved
torrent/api/src/commonTest/kotlin/api/pieces/TorrentDownloadControllerTest.kt
Show resolved
Hide resolved
torrent/api/src/commonTest/kotlin/api/pieces/TorrentDownloadControllerTest.kt
Show resolved
Hide resolved
| finishPiece(100) | ||
| assertEquals(listOf(2, 3, 4, 6, 7, 8, 9, 10, 11, 13, 997, 998, 999), currentDownloadingPieces.sorted()) | ||
|
|
||
| // 不会重复请求已经完成的 piece |
| (10..99).forEach { finishPiece(it) } | ||
| assertEquals(listOf(2, 3, 4, 6, 7, 8, 9, 101, 102, 103, 997, 998, 999), currentDownloadingPieces.sorted()) | ||
|
|
||
| // seek 到 200, seek 后面的地方不会请求 footer |
torrent/api/src/commonTest/kotlin/api/pieces/TorrentDownloadControllerTest.kt
Show resolved
Hide resolved
torrent/api/src/commonTest/kotlin/api/pieces/TorrentDownloadControllerTest.kt
Show resolved
Hide resolved
| finishPiece(996) | ||
| controller.onSeek(100) | ||
| assertEquals(listOf(995, 997), currentDownloadingPieces.sorted()) | ||
| } |
There was a problem hiding this comment.
没有测试有 overlap 的 seek.
例如:
- seek 100 -> seek 102
- seek 100 -> seek 98
- seek 990 (footer 范围内) -> seek 985. 期望 footer 仍然在 window 内
- seek 1 (header 范围内) -> seek 20. 期望 header 仍然在 window 内
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TorrentDownloaderController 无法工作