Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure warning for CCM deactivation password flag #201

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

zaidusmani26
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (a946bf1) 81.92% compared to head (b1bef2a) 81.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   81.92%   81.94%   +0.01%     
==========================================
  Files          24       24              
  Lines        3337     3340       +3     
==========================================
+ Hits         2734     2737       +3     
  Misses        485      485              
  Partials      118      118              
Files Changed Coverage Δ
internal/local/deactivate.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@zaidusmani26 zaidusmani26 force-pushed the localPasswordPrompt branch 12 times, most recently from eb0aa6e to 5aea375 Compare September 6, 2023 07:09
@zaidusmani26 zaidusmani26 changed the title feat: Add password prompt for local activation feat: Ensure warning for CCM deactivation password flag Sep 6, 2023
@zaidusmani26 zaidusmani26 changed the title feat: Ensure warning for CCM deactivation password flag feat: ensure warning for CCM deactivation password flag closes# 18321 Sep 7, 2023
@zaidusmani26 zaidusmani26 marked this pull request as draft September 7, 2023 17:41
@zaidusmani26 zaidusmani26 force-pushed the localPasswordPrompt branch 2 times, most recently from 1035abd to 84ac695 Compare September 7, 2023 18:59
@zaidusmani26 zaidusmani26 changed the title feat: ensure warning for CCM deactivation password flag closes# 18321 feat: ensure warning for CCM deactivation password flag Sep 7, 2023
@zaidusmani26 zaidusmani26 marked this pull request as ready for review September 7, 2023 18:59
@zaidusmani26 zaidusmani26 force-pushed the localPasswordPrompt branch 2 times, most recently from 2247f61 to 9aae346 Compare September 7, 2023 19:11
@zaidusmani26 zaidusmani26 changed the title feat: ensure warning for CCM deactivation password flag fix: ensure warning for CCM deactivation password flag Sep 8, 2023
@madhavilosetty-intel madhavilosetty-intel merged commit 35b3bce into main Sep 8, 2023
13 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the localPasswordPrompt branch September 8, 2023 17:05
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 2.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

zaidusmani26 pushed a commit that referenced this pull request Sep 11, 2023
fix: ensure warning for CCM deactivation password flag
zaidusmani26 pushed a commit that referenced this pull request Sep 11, 2023
fix: ensure warning for CCM deactivation password flag
zaidusmani26 pushed a commit that referenced this pull request Sep 11, 2023
fix: ensure warning for CCM deactivation password flag
zaidusmani26 pushed a commit that referenced this pull request Sep 11, 2023
fix: ensure warning for CCM deactivation password flag
zaidusmani26 pushed a commit that referenced this pull request Sep 11, 2023
fix: ensure warning for CCM deactivation password flag
zaidusmani26 pushed a commit that referenced this pull request Sep 14, 2023
fix: ensure warning for CCM deactivation password flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants