Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.11 update (separate manifest), 1.11 Documenter #34

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

arlowhite
Copy link
Contributor

@arlowhite arlowhite commented Oct 9, 2024

Split manifest for Julia 1.10 & 1.11, Pkg update

Change Documenter GitHub workflow to 1.11, ] update

Only run docs action on PRs when Manifest.toml changed

Notes

Julia 1.11 has a new bug with Oxygen OxygenFramework/Oxygen.jl#226
This causes one request to fail after startup.

Docker

Wanted to bump Docker containers to 1.11, but leaving on 1.10 for now due to these issues.
Created issue #40

docker build . --target reefguide-src -t reefguide_1_10 --no-cache
Julia 1.10 build took 5m22s
Julia 1.11 build took 18m22s

Toward the end of the 1.11 build, these warnings are printed for every package. (not in 1.10)

Warning: Module StaticArrays with build ID ffffffff-ffff-ffff-0000-46a203311587 is missing from the cache.
This may mean StaticArrays [90137ffa-7385-5640-81b9-e52037218182] does not support precompilation but is imported by a module that does.

@arlowhite
Copy link
Contributor Author

arlowhite commented Oct 9, 2024

docker build is taking a long time. 926s
=> [reefguide-src reefguide-src 6/6] RUN julia --project=@reefguide -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.precompile(); using ReefGuideAPI;'
I'm seeing warnings like this for every package.

 => => # ┌ Warning: Module Setfield with build ID ffffffff-ffff-ffff-0000-4025972e8126 is missing from the cache.                                                                                                                                                                             
 => => # │ This may mean Setfield [efcf1570-3423-57d1-acb7-fd33fddbac46] does not support precompilation but is imported by a module that does. 

I don't recall those with 1.10, but maybe they were there. Would be interesting to compare 1.10 docker build time with 1.11

@arlowhite arlowhite marked this pull request as draft October 9, 2024 06:13
@arlowhite
Copy link
Contributor Author

I get this error only with the docker container

2024-10-09 15:58:36 [ Info: Launching server... please wait
2024-10-09 15:58:36 [ Info: Parsing configuration from /data/reefguide/config.toml...
2024-10-09 15:58:36 [ Info: Setting up auth middleware and router.
2024-10-09 15:58:36 [ Info: Setting up region routes...
2024-10-09 15:58:39 ERROR: type Nothing has no field geometry
2024-10-09 15:58:39 Stacktrace:
2024-10-09 15:58:39  [1] getproperty
2024-10-09 15:58:39    @ ./Base.jl:49 [inlined]
2024-10-09 15:58:39  [2] setup_regional_data(config::Dict{String, Any})
2024-10-09 15:58:39    @ ReefGuideAPI /usr/local/src/reefguide/src/ReefGuideAPI.jl:109
2024-10-09 15:58:39  [3] setup_region_routes(config::Dict{String, Any}, auth::Oxygen.Core.RouterHOF.var"#2#6"{Nothing, Nothing, Oxygen.Core.RouterHOF.var"#2#3#7"{Oxygen.Core.AppContext.Context, String, Vector{String}, Vector{typeof(identity)}, Oxygen.Core.RouterHOF.var"#fixpath#5"}})
2024-10-09 15:58:39    @ ReefGuideAPI /usr/local/src/reefguide/src/criteria_assessment/criteria.jl:106
2024-10-09 15:58:39  [4] start_server(config_path::String)
2024-10-09 15:58:39    @ ReefGuideAPI /usr/local/src/reefguide/src/ReefGuideAPI.jl:212
2024-10-09 15:58:39  [5] top-level scope
2024-10-09 15:58:39    @ none:1

@ConnectedSystems
Copy link
Collaborator

Suspect it's something to do with the cache. Does the build process include the cache warmup?

@arlowhite
Copy link
Contributor Author

Docker container is working. I had data directory volume misconfigured. Though would be good to have a better error message in that situation.

@arlowhite arlowhite marked this pull request as ready for review October 15, 2024 03:36
@arlowhite arlowhite changed the title Julia 1.11 update Julia 1.11 update (separate manifest), 1.11 Documenter Oct 15, 2024
@arlowhite arlowhite merged commit 25fe2a8 into main Oct 20, 2024
@arlowhite arlowhite deleted the julia-1-11-update branch October 20, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants