Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fill eip 7702 tx env with auth list #958

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 28, 2025

Fills tx env for EIP 7702 transactions using the same format as EIP 1559, but with authorization list added.

Fixes #948

TODO: do we need a switch for Isthmus here? Or is it OK to be active all the time - guessing the batcher shouldn't include 7702 txs until Isthmus is active?

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. makes most sense to have a switch to check if isthmus is active in scope of caller of prepare_tx_env.

@refcell refcell force-pushed the meyer9/fill-7702-tx-env branch from ee114e4 to 6b69eb4 Compare January 28, 2025 16:27
@refcell
Copy link
Collaborator

refcell commented Jan 28, 2025

I've updated the calling context of prepare_tx_env to prevent EIP-7702 txs if isthmus is not active as previous behavior.

@meyer9
Copy link
Contributor Author

meyer9 commented Jan 28, 2025

awesome, thanks!

@refcell refcell merged commit debed6a into op-rs:main Jan 28, 2025
13 of 14 checks passed
This was referenced Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(executor): Fill EIP-7702 transaction environment after Isthmus
3 participants