Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the dnscheck list #1656

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Simplify the dnscheck list #1656

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b363fc2
Simplify the dnscheck list
hellais Oct 14, 2024
ca83849
refactor: separate default and extended dnscheck targets
DecFox Nov 21, 2024
03d6f6e
refactor: remove unrequired prefix underscore
DecFox Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 105 additions & 0 deletions internal/experiment/dnscheck/richerinput.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,111 @@ func (tl *targetLoader) Load(ctx context.Context) ([]model.ExperimentTarget, err
}

var defaultInput = []model.ExperimentTarget{
//
// https://dns.google/dns-query
//
// Measure HTTP/3 first and then HTTP/2 (see https://github.com/ooni/probe/issues/2675).
//
// Make sure we include the typical IP addresses for the domain.
//
&Target{
URL: "https://dns.google/dns-query",
Config: &Config{
HTTP3Enabled: true,
DefaultAddrs: "8.8.8.8 8.8.4.4",
},
},
&Target{
URL: "https://dns.google/dns-query",
Config: &Config{
DefaultAddrs: "8.8.8.8 8.8.4.4",
},
},
&Target{
URL: "https://cloudflare-dns.com/dns-query",
Config: &Config{
HTTP3Enabled: true,
DefaultAddrs: "1.1.1.1 1.0.0.1",
},
},
&Target{
URL: "https://cloudflare-dns.com/dns-query",
Config: &Config{
DefaultAddrs: "1.1.1.1 1.0.0.1",
},
},
&Target{
URL: "https://dns.quad9.net/dns-query",
Config: &Config{
HTTP3Enabled: true,
DefaultAddrs: "9.9.9.9",
},
},
&Target{
URL: "https://dns.quad9.net/dns-query",
Config: &Config{
DefaultAddrs: "9.9.9.9",
},
},
&Target{
URL: "https://dns.adguard.com/dns-query",
Config: &Config{
HTTP3Enabled: true,
},
},
&Target{
URL: "https://dns.adguard.com/dns-query",
Config: &Config{},
},
&Target{
URL: "https://dns.alidns.com/dns-query",
Config: &Config{
HTTP3Enabled: true,
},
},
&Target{
URL: "https://dns.alidns.com/dns-query",
Config: &Config{},
},
&Target{
URL: "https://doh.opendns.com/dns-query",
Config: &Config{
HTTP3Enabled: true,
},
},
&Target{
URL: "https://doh.opendns.com/dns-query",
Config: &Config{},
},
&Target{
URL: "https://dns.nextdns.io/dns-query",
Config: &Config{
HTTP3Enabled: true,
},
},
&Target{
URL: "https://dns.nextdns.io/dns-query",
Config: &Config{},
},

&Target{
URL: "https://dns.switch.ch/dns-query",
Config: &Config{
HTTP3Enabled: true,
},
},
&Target{
URL: "https://dns.switch.ch/dns-query",
Config: &Config{},
},
}

// extendedInput is an extended input target list for dnscheck.
// TODO(decfox): we should have a flag to return the extended list in special cases
// while using the default list for normal runs.
//
//lint:ignore U1000 ignore unused var
var extendedInput = []model.ExperimentTarget{
//
// https://dns.google/dns-query
//
Expand Down
Loading