Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oohelperd: move prometheus metrics behind HTTP basic auth + docker image build + codepipeline buildspec #1520

Merged
merged 2 commits into from
Mar 19, 2024
Merged

oohelperd: move prometheus metrics behind HTTP basic auth + docker image build + codepipeline buildspec #1520

merged 2 commits into from
Mar 19, 2024
+127 −12

Conversation

hellais
Copy link
Member

@hellais hellais commented Mar 19, 2024 •
edited
Loading

We implement the following changes:

  • Move prometheus metric behind HTTP basic auth
  • Read the prometheus password from the PROMETHEUS_METRICS_PASSWORD environment variable like we do for ooniapi-services
  • Add Dockerfile to build oohelpderd
  • Add codepipeline buildspec for oonihelpderd

@hellais hellais requested a review from bassosimone as a code owner March 19, 2024 12:51
@hellais hellais requested review from DecFox and removed request for bassosimone March 19, 2024 12:51
DecFox
DecFox approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellais
Copy link
Member Author

hellais commented Mar 19, 2024

This implements what we discussed in ooni/devops#31 (comment)

@hellais hellais merged commit 4575516 into master Mar 19, 2024
25 checks passed
@hellais hellais deleted the oohelperd branch March 19, 2024 13:11
@hellais hellais mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecFox DecFox DecFox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellais @DecFox