Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dslx): prepare for making HTTPRequest stateless #1380

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refactor(dslx): prepare for making HTTPRequest stateless #1380

merged 2 commits into from
Oct 25, 2023

Conversation

bassosimone
Copy link
Contributor

  • avoid storing state for creating an http.Request in httpRequestFunc

  • avoid using methods for constructing an http.Request where we can use pure functions instead

  • update and adapt the unit test suite

Reference issue: ooni/probe#2612

@bassosimone
refactor(dslx): prepare for making HTTPRequest stateless
b54d29c 
- avoid storing state for creating an http.Request in httpRequestFunc

- avoid using methods for constructing an http.Request where we
can use pure functions instead

- update and adapt the unit test suite

Reference issue: ooni/probe#2612
@bassosimone bassosimone requested a review from hellais as a code owner October 25, 2023 07:58
@bassosimone bassosimone merged commit f05748e into master Oct 25, 2023
@bassosimone bassosimone deleted the issue/2545-small-3 branch October 25, 2023 08:15
@BrewTestBot BrewTestBot mentioned this pull request Dec 13, 2023
Merged
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor(dslx): prepare for making HTTPRequest stateless (ooni#1380)
8da6341 
- avoid storing state for creating an http.Request in httpRequestFunc

- avoid using methods for constructing an http.Request where we can use
pure functions instead

- update and adapt the unit test suite

Reference issue: ooni/probe#2612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone