Skip to content

Commit

Permalink
tests now green
Browse files Browse the repository at this point in the history
what remains to be done now is to make sure we make green all the
tests that are currently skipped

we also need to account for differences between the two
  • Loading branch information
bassosimone committed Nov 25, 2023
1 parent 18da855 commit e7764c8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/experiment/webconnectivityqa/badssl.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ func badSSLWithUnknownAuthorityWithInconsistentDNS() *TestCase {
},
ExpectErr: false,
ExpectTestKeys: &testKeys{
BodyLengthMatch: true,
StatusCodeMatch: true,
HeadersMatch: true,
TitleMatch: true,
DNSConsistency: "inconsistent",
HTTPExperimentFailure: "ssl_unknown_authority",
XStatus: 9248, // StatusExperimentHTTP | StatusAnomalyTLSHandshake | StatusAnomalyDNS
Expand Down
4 changes: 4 additions & 0 deletions internal/experiment/webconnectivityqa/dnsblocking.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ func dnsBlockingAndroidDNSCacheNoData() *TestCase {
},
ExpectErr: false,
ExpectTestKeys: &testKeys{
BodyLengthMatch: true,
StatusCodeMatch: true,
HeadersMatch: true,
TitleMatch: true,
DNSExperimentFailure: "android_dns_cache_no_data",
DNSConsistency: "inconsistent",
XStatus: 2080, // StatusExperimentDNS | StatusAnomalyDNS
Expand Down

0 comments on commit e7764c8

Please sign in to comment.