x

ooni · Jan 24, 2024 · d7df251 · d7df251
1 parent 60ebc7a
commit d7df251
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/experiment/webconnectivitylte/analysisclassic.go b/internal/experiment/webconnectivitylte/analysisclassic.go
@@ -375,7 +375,7 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk
 
 			// 5.3. When the probe says dns_no_answer the control would otherwise say that
 			// we have resolved zero IP addresses for historical reasons. In such a case,
-			// let's pretend also the control returned dns_no_answer.
+			// let's pretend that also the control returned dns_no_answer.
 			if entry.Failure.Unwrap() == netxlite.FailureDNSNoAnswer &&
 				!entry.ControlDNSResolvedAddrs.IsNone() &&
 				entry.ControlDNSResolvedAddrs.Unwrap().Len() <= 0 {

diff --git a/internal/minipipeline/analysis.go b/internal/minipipeline/analysis.go
@@ -453,7 +453,7 @@ func (wa *WebAnalysis) dnsComputeFailureMetrics(c *WebObservationsContainer) {
 		if failure := obs.DNSLookupFailure.Unwrap(); failure != "" {
 			// When the probe says dns_no_answer the control would otherwise say that
 			// we have resolved zero IP addresses for historical reasons. In such a case,
-			// let's pretend also the control returned dns_no_answer.
+			// let's pretend that also the control returned dns_no_answer.
 			if failure == netxlite.FailureDNSNoAnswer {
 				if !obs.ControlDNSResolvedAddrs.IsNone() && obs.ControlDNSResolvedAddrs.Unwrap().Len() <= 0 {
 					wa.DNSLookupExpectedFailure.Add(obs.DNSTransactionID.Unwrap())