Skip to content

Commit

Permalink
[ci skip] remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Nov 27, 2023
1 parent 258d7fb commit c6a49ff
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions internal/experiment/webconnectivityqa/tcpblocking.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ import (
// where the connection is timed out.
func tcpBlockingConnectTimeout() *TestCase {
return &TestCase{
Name: "tcpBlockingConnectTimeout",
// TODO(bassosimone): this test case transitions from 2 (TCP/IP blocking) to
// 10 (both TCP/IP blocking and HTTP blocking). The reason why this happens is
// that we're now adding an HTTP request to the mix. This is unfortunate. We
// should not flag HTTP failures here inside of the bitmask.
Name: "tcpBlockingConnectTimeout",
Flags: 0,
Input: "https://www.example.com/",
Configure: func(env *netemx.QAEnv) {
Expand Down

0 comments on commit c6a49ff

Please sign in to comment.