Skip to content

Commit

Permalink
x
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Oct 25, 2023
1 parent 9755905 commit 9796f4b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions internal/dslx/httpcore.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func httpRoundTrip(
input *HTTPConnection,
req *http.Request,
) (*http.Response, []byte, []*Observations, error) {
const maxbody = 1 << 19 // TODO(bassosimone): allow to configure this value?
const maxbody = 1 << 19 // TODO(https://github.com/ooni/probe/issues/2621): allow to configure this value
started := input.Trace.TimeSince(input.Trace.ZeroTime())

// manually create a single 1-length observations structure because
Expand Down Expand Up @@ -249,7 +249,7 @@ func httpRoundTrip(

// read a snapshot of the response body
reader := io.LimitReader(resp.Body, maxbody)
body, err = netxlite.ReadAllContext(ctx, reader) // TODO: enable streaming and measure speed
body, err = netxlite.ReadAllContext(ctx, reader) // TODO(https://github.com/ooni/probe/issues/2622)

// collect and save download speed samples
samples := sampler.ExtractSamples()
Expand Down
2 changes: 1 addition & 1 deletion internal/dslx/qa_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func TestDNSLookupQA(t *testing.T) {
t.Fatal(diff)
}

// TODO(bassosimone): make sure the observations are OK
// TODO(https://github.com/ooni/probe/issues/2620): make sure the observations are OK
})
}
}
Expand Down

0 comments on commit 9796f4b

Please sign in to comment.