refactor(webconnectivitylte): {Append,Prepend}Requests (#1396)

The new name is more accurate because we need to prepend to requests such that the last request ends up being first in the list. Part of ooni/probe#2634
ooni · Nov 28, 2023 · 683d20c · 683d20c
1 parent 719c3c2
commit 683d20c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/internal/experiment/webconnectivitylte/cleartextflow.go b/internal/experiment/webconnectivitylte/cleartextflow.go
@@ -274,7 +274,7 @@ func (t *CleartextFlow) httpTransaction(ctx context.Context, network, address, a
 		err,
 		finished,
 	)
-	t.TestKeys.AppendRequests(ev)
+	t.TestKeys.PrependRequests(ev)
 	return resp, body, err
 }
 

diff --git a/internal/experiment/webconnectivitylte/secureflow.go b/internal/experiment/webconnectivitylte/secureflow.go
@@ -329,7 +329,7 @@ func (t *SecureFlow) httpTransaction(ctx context.Context, network, address, alpn
 		err,
 		finished,
 	)
-	t.TestKeys.AppendRequests(ev)
+	t.TestKeys.PrependRequests(ev)
 	return resp, body, err
 }
 

diff --git a/internal/experiment/webconnectivitylte/testkeys.go b/internal/experiment/webconnectivitylte/testkeys.go
@@ -217,8 +217,8 @@ func (tk *TestKeys) AppendQueries(v ...*model.ArchivalDNSLookupResult) {
 	tk.mu.Unlock()
 }
 
-// AppendRequests appends to Requests.
-func (tk *TestKeys) AppendRequests(v ...*model.ArchivalHTTPRequestResult) {
+// PrependRequests prepends to Requests.
+func (tk *TestKeys) PrependRequests(v ...*model.ArchivalHTTPRequestResult) {
 	tk.mu.Lock()
 	// Implementation note: append at the front since the most recent
 	// request must be at the beginning of the list.