Add header order configurabillity #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not necessarily out of scope for us, as it's something we wanted to do per ooni/probe#2160. I may be slow to review these changes though, since my Sprint Planning is quite packed 😅. |
|
Nice, it would be great to see this in oohttp at some point then. |
# Conflicts: # h2_bundle.go
# Conflicts: # h2_bundle.go
feat: compressor streamable and lazy-init, hot path
fix: write request extra header to wire
fix: accept-encoding fallback gzip
fix: extra header orderable
fix: h2 bundle decompress encoding order
# Conflicts: # go.mod # go.sum # request.go
Feat/merge upstream
fix: revert to the old way of checking for user agent presence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to order the headers in a specific way to emulate other HTTP clients, eg browsers.
While header order is not strictly covered in the HTTP spec, it's widely known that each HTTP client tends to send headers in a slightly different order. This allows you to fingerprint and filter traffic by the order of the header present in a HTTP request.
Some more sources on the situation at hand:
https://www.os3.nl/_media/2014-2015/courses/rp2/p91_report.pdf
https://my.f5.com/manage/s/article/K13527565
https://sansec.io/research/http-header-order-is-important
This may be out of scope for OONI's oohttp project, if that's the case I will most likely end up maintaining this in a separate
fork.