Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce data channel layer #53

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

ainghazal
Copy link
Collaborator

@ainghazal ainghazal commented Jan 19, 2024

This is the sixth commit in the series of incremental refactoring of the current minivpn tree.

In this commit, we introduce the datachannel package. This layer is above TLS and it communicates with TLS, the Packet Muxer and TUN. It is also the last layer below the TUN interface.

datachannel has two channels to communicate with the muxer, two channels to move cleartext bytes to the TUN interface, and one channel to receive keys from TLS.

Reference issue: #47

@ainghazal ainghazal requested a review from bassosimone January 19, 2024 12:31
@ainghazal ainghazal self-assigned this Jan 19, 2024
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss the implementation of the Service.

internal/datachannel/controller.go Outdated Show resolved Hide resolved
internal/datachannel/controller.go Outdated Show resolved Hide resolved
internal/datachannel/crypto.go Show resolved Hide resolved
internal/datachannel/service.go Outdated Show resolved Hide resolved
internal/datachannel/service.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@ainghazal ainghazal merged commit 6c0c4cd into ooni:main Jan 19, 2024
@ainghazal ainghazal deleted the refactor-datachannel branch January 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants