refactor: introduce the networkio layer #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried to achieve te minimal incremental change that adds resilience in the face of network noise. To achieve that, the simple thing to do was to make session an object owned by an implementation of reliableTransport. I've reused the reliableUDP implementation in govpn, and I like the simplicity of that implementation a lot. A lot of our current logic (ackqueue/retries) needed to move from the tlsTransport minivpn implementation into reliableTransport. Although the DoS documented in the MIV-01 report is not done, we add the e2e testing script to facilitate further development. - Related: ooni#32 more tests
Discussed with @ainghazal extensively.
In particular, make sure it's ~easy to connect them all.
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
reviewed
Jan 10, 2024
bassosimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the lower layer in the new layered minivpn architecture. This new architecture has already been implemented in an integration branch. The general idea is to split functionality by layers that we can reason about and write tests for more easily. Each layer will communicate with other layers through channels. Also, each layer will run a bunch of worker for performing channel or network-based I/O. Here, in particular, we're adding the network I/O layer on top of which the rest of the architecture is based, as well as all the required dependencies for making the code compile.
Reference issue: #47