set verbosity conditined on verbose tests

ooni · Feb 7, 2024 · 55492eb · 55492eb
1 parent d70fac8
commit 55492eb
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 17 deletions.
diff --git a/internal/reliabletransport/receiver_test.go b/internal/reliabletransport/receiver_test.go
@@ -26,7 +26,9 @@ func Test_newReliableReceiver(t *testing.T) {
 }
 
 func Test_reliableQueue_MaybeInsertIncoming(t *testing.T) {
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type fields struct {
 		incomingPackets incomingSequence
@@ -91,7 +93,9 @@ func Test_reliableQueue_MaybeInsertIncoming(t *testing.T) {
 }
 
 func Test_reliableQueue_NextIncomingSequence(t *testing.T) {
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type fields struct {
 		lastConsumed    model.PacketID

diff --git a/internal/reliabletransport/reliable_ack_test.go b/internal/reliabletransport/reliable_ack_test.go
@@ -23,8 +23,9 @@ import (
     ack
 */
 func TestReliable_ACK(t *testing.T) {
-
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type args struct {
 		inputSequence []string

diff --git a/internal/reliabletransport/reliable_loss_test.go b/internal/reliabletransport/reliable_loss_test.go
@@ -23,7 +23,6 @@ drop◄─┤         │
       ▼relay (ack)
 */
 func TestReliable_WithLoss(t *testing.T) {
-
 	if testing.Verbose() {
 		log.SetLevel(log.DebugLevel)
 	}

diff --git a/internal/reliabletransport/reliable_reorder_test.go b/internal/reliabletransport/reliable_reorder_test.go
@@ -11,18 +11,19 @@ import (
 
 // test that we're able to reorder (towards TLS) whatever is received (from the muxer).
 //
-//	           dataOut
+//		           dataOut
+//		              ▲
+//		              │
+//		 ┌────┐    ┌──┴─┐
+//		 │sndr│    │rcvr│
+//		 └────┘    └────┘
 //	              ▲
-//	              │
-//	 ┌────┐    ┌──┴─┐
-//	 │sndr│    │rcvr│
-//	 └────┘    └────┘
-//				▲
-//				|
-//	           dataIn
+//	             |
+//		          dataIn
 func TestReliable_Reordering_UP(t *testing.T) {
-
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type args struct {
 		inputSequence  []string

diff --git a/internal/reliabletransport/sender_test.go b/internal/reliabletransport/sender_test.go
@@ -34,7 +34,9 @@ func Test_newReliableSender(t *testing.T) {
 }
 
 func Test_reliableSender_TryInsertOutgoingPacket(t *testing.T) {
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type fields struct {
 		inFlight inflightSequence
@@ -106,7 +108,9 @@ func Test_reliableSender_TryInsertOutgoingPacket(t *testing.T) {
 }
 
 func Test_reliableSender_NextPacketIDsToACK(t *testing.T) {
-	log.SetLevel(log.DebugLevel)
+	if testing.Verbose() {
+		log.SetLevel(log.DebugLevel)
+	}
 
 	type fields struct {
 		pendingACKsToSend []model.PacketID