Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return array of pointers in get account keys for consistency #792

Conversation

illia-malachyn
Copy link
Contributor

Closes: #783

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (38ecc3c) to head (2f7fa8b).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 0.00% 3 Missing ⚠️
access/grpc/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   57.03%   56.59%   -0.45%     
==========================================
  Files          35       35              
  Lines        7392     7305      -87     
==========================================
- Hits         4216     4134      -82     
+ Misses       2674     2670       -4     
+ Partials      502      501       -1     
Flag Coverage Δ
unittests 56.59% <28.57%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franklywatson franklywatson merged commit 5b17d2d into onflow:master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update streaming endpoints to return pointers
6 participants