Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest Cadence 1.0 preview #557

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dsainati1
Copy link
Contributor

Updating to cadence https://github.com/onflow/cadence/releases/tag/v1.0.0-preview.2


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@dsainati1 dsainati1 added the Dependencies Pull requests that update a dependency file label Jan 16, 2024
@dsainati1 dsainati1 requested a review from a team January 16, 2024 19:34
@dsainati1 dsainati1 self-assigned this Jan 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69feed3) 62.30% compared to head (bcd303f) 62.30%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence     #557   +/-   ##
=======================================================
  Coverage                   62.30%   62.30%           
=======================================================
  Files                          24       24           
  Lines                        2966     2966           
=======================================================
  Hits                         1848     1848           
  Misses                        994      994           
  Partials                      124      124           
Flag Coverage Δ
unittests 62.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member

Is feature/stable-cadence itself up-to-date?

@dsainati1
Copy link
Contributor Author

Up to date in what sense?

@turbolent
Copy link
Member

Sorry, I meant up-to-date with master (only slightly related to this PR)

@turbolent
Copy link
Member

Just checked again: flow-go still uses the old cypto library, https://github.com/onflow/flow-go/blob/master/go.mod#L58C32-L58C37, so the feature branch should still be based on the v0.41 branch here (master uses the new crypto library). So all good, ignore the comments above

@turbolent turbolent merged commit 4b99247 into feature/stable-cadence Jan 17, 2024
1 check passed
@turbolent turbolent deleted the sainati/update-stable-cadence branch January 17, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants