Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reactive State Management using Observabales #2098

Merged
merged 27 commits into from
Jan 31, 2025
Merged

Implement Reactive State Management using Observabales #2098

merged 27 commits into from
Jan 31, 2025

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 31, 2025 •
edited
Loading

Closes #2101

  1. Switch EventDispatcher to using observables under the hood
  2. Switch AccountManager to using observable-based store

@jribbink jribbink requested a review from a team as a code owner January 31, 2025 02:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9d0315c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink marked this pull request as draft January 31, 2025 02:09
@jribbink jribbink changed the base branch from master to feature/cross-vm January 31, 2025 02:16
@jribbink jribbink changed the base branch from feature/cross-vm to jribbink/chain-changed January 31, 2025 02:51
@jribbink jribbink changed the base branch from jribbink/chain-changed to feature/cross-vm January 31, 2025 18:52
@jribbink jribbink changed the title Switch to using observables for state management Implement reactive state management using observer pattern Jan 31, 2025
@jribbink jribbink changed the title Implement reactive state management using observer pattern Implement Reactive State Management using Observer Pattern Jan 31, 2025
@jribbink jribbink changed the title Implement Reactive State Management using Observer Pattern Implement Reactive State Management & Observables Jan 31, 2025
@jribbink jribbink marked this pull request as ready for review January 31, 2025 20:21
@jribbink jribbink mentioned this pull request Jan 31, 2025
Merged
@jribbink jribbink changed the title Implement Reactive State Management & Observables Implement Reactive State Management using Observabales Jan 31, 2025
@jribbink jribbink marked this pull request as draft January 31, 2025 20:28
@jribbink jribbink marked this pull request as ready for review January 31, 2025 20:44
@jribbink jribbink merged commit 167277e into feature/cross-vm Jan 31, 2025
1 check passed
@jribbink jribbink deleted the jribbink/observables branch January 31, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @chasefleming