Limit number of goroutines in FastCommit() #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially improves: #267
Description
Currently,
PersistentSlabStorage.FastCommit()
creates goroutines during runtime.This may be a bit inefficient in cases where there is a small number of keys and a high number of CPUs. For now, simply upper-bound the number of goroutines by the number keys.
main
branchFiles changed
in the Github PR explorer