Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support React19 #298

Closed
wants to merge 1 commit into from

Conversation

a-treschilov
Copy link

@a-treschilov a-treschilov commented Jan 2, 2025

Fixes #287.

This PR supports React 19, at the same time there are no support React 17, 18 and NextJs 14 anymore.

react-jsx is no longer needed as well, because NextJs optimizes JSX from the box

@a-treschilov a-treschilov mentioned this pull request Jan 2, 2025
@cosminc-am
Copy link

+1

@davecarlson
Copy link

when is this landing @onesine

@onesine
Copy link
Owner

onesine commented Feb 1, 2025

when is this landing @onesine

Hi @davecarlson ,
There are some changes in this PR that I don't understand yet. Reason why it is not yet considered.

What's more, React 19 support doesn't normally need all these modifications.

@onesine
Copy link
Owner

onesine commented Feb 2, 2025

Hi @a-treschilov,

Sorry I can't accept this PR or make any modification remarks.

I had to add some additional adjustments to ensure compatibility with React 19. I could have asked you to incorporate these changes directly into the PR, but not knowing your availability, it might have taken some time. For my part, I also had to be available to review and validate them, although I wanted them to be available as soon as possible.

That's why I took the initiative of integrating everything myself. I apologize for this and hope to have the opportunity to collaborate with you on a future PR very soon.

I've just released a new version that supports react version 19. For more details you can consult Release 1.7.4..

@onesine onesine closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 19 Build
5 participants