Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 add exclusivity operators #28

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

ccoquand
Copy link
Collaborator

Description

Add hasInterferingServices and hasNonInterferingServices as operators pour type Hardware.
Add inference rule for interfereWith and nonInterfereWith operators for Hardware/Hardware type.

Warning: There is a priority conflict between InterfereRelation and NonInterfereRelation, the first one seems to have priority over the second one.

What type of pull request is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Style
  • Code Refactor
  • Performance Improvements
  • Test
  • Build
  • CI
  • Chore (Release)
  • Revert

Related Tickets & Documents

If possible ensure that you have provided in your commit message the issue id (available here) this pull request fixes,
for instance to refer to issue #42 you can do:

git commit -m "solving issue #42 with ..."

Check here for more information

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • README.md
  • doc
  • no documentation needed

Do we need to update pml analyzer version?

  • no
  • the pull request is only a bug fix, need a bug fix version update
  • the pull request add new features and ensures retro-compatibility, need a feature addition version update
  • the pull request is not ensuring retro-capatibility, need a major version update
  • not sure, I need help

Is this new version should be released as soon as possible?

  • yes
  • no
  • not sure, I need help

…dd inference rule for interfereWith and notInterfereWith operators for Hardware/Hardware type
…hasNonInterferingServices, raise error on priority of Interfere relation over NotInterfere relation
@ccoquand ccoquand linked an issue Jan 24, 2025 that may be closed by this pull request
Copy link
Collaborator

@kevin-delmas kevin-delmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging it would be nice to add a test class that is checking that interfereWith update the hardwareInterfereRelation (and its not interfere countpart) on a simple example. Same request for the hasInterfering/hasNonInterfering services.
The CI is not working due to an external change in the available action to mount an SBT image. I will take care of that with a rebase of this branch on master once the patch from issue #20 has been merged

ccoquand and others added 4 commits January 24, 2025 15:46
…dd inference rule for interfereWith and notInterfereWith operators for Hardware/Hardware type
…hasNonInterferingServices, raise error on priority of Interfere relation over NotInterfere relation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exclusivity operators
2 participants