-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pypi release #498
Pypi release #498
Conversation
Very cool ! |
On versioning scheme, I think we should use the same scheme than the one we used with python-client ( |
I asked about the versioning scheme, because it is a somewhat complex question.
I think it makes sense to consider CalVer, which would essentially mean "this project is constantly improved, the release version means nothing and we don't guarantee any kind of stability between versions". Maye this would manage user expectations better? |
Agree, I would use preferably calver, like this: YYYY.MM.DD or YYYY.MM.MICRO otherwise in semver, I would go for a 1.1.0 release now as I think we are stable for a while. |
I added documentation in the install section on how to install from PyPI. |
There are 3 milestones, none of them are closed: https://github.com/onekey-sec/unblob/milestones Or we could use calver immediately with no guarantees and delete the milestones 😄 |
Marked as ready. Let's use calendar versioning (my preference goes to |
This specific YAML fields need a string, not a float.
Removed global install recommendation, as it can potentially break the system.
8940285
to
69a3878
Compare
I made the GitHub Action to release the Python package to PyPI, the same as we did for
https://github.com/onekey-sec/python-client.
WIP, because you need to come up with a versioning scheme before this can be used.
I think the
POETRY_PYPI_TOKEN_PYPI
secret is org level, but I don't remember, need to be checked.Fixes #493